Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to examples #45

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Fix links to examples #45

merged 2 commits into from
Dec 8, 2022

Conversation

ronen
Copy link
Contributor

@ronen ronen commented Nov 22, 2022

The links to the examples were based off "." but in the rendered context that created garbled paths yielding 404s.

I think this change fixes it. It looks good in the preview, though unfortunately I wouldn't be 100% sure until it was actually installed.

@stefanbenten stefanbenten requested a review from zeebo November 23, 2022 00:09
@zeebo
Copy link
Collaborator

zeebo commented Nov 23, 2022

This looks great. The CI failures are not your fault, and should be resolved soon. I'll merge this then.

zeebo
zeebo previously approved these changes Nov 23, 2022
@zeebo zeebo merged commit 39e5059 into storj:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants